fix: add risc0 feature to celestia adapter
#1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests are currently breaking as they require an optional `risc0-zkvm` dependency, assuming it is always available. A new feature is required to shield such case. This commit also introduces a check on `cargo hack` to inspect all targets. This will prevent the same problem from happening in the future. Finally, it removes the unused `default` argument from `cargo hack`, as it conflicts with `all-targets`.
bkolad
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are currently breaking as they require an optional
risc0-zkvmdependency, assuming it is always available. A new feature is required to shield such case.This commit also introduces a check on
cargo hackto inspect all targets. This will prevent the same problem from happening in the future. Finally, it removes the unuseddefaultargument fromcargo hack, as it conflicts withall-targets.